Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden Lambda FIFO integration tests. #78

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

ashovlin
Copy link
Contributor

Issue #, if available: N/A, follow-up to #71

Description of changes: @96malhar pointed out that the new Lambda FIFO integration test failed on his PR #77. Ran them continually locally, and saw failures in the 5-10 iteration range.

I'm now able to get to 10 iterations without failures (at which point I stopped) with these changes:

  • For the FIFO messages logged to CloudWatch by the Lambda, we sort based on Timestamp instead of IngestionTime. I believe that is more accurate for when the Lambda function handled the message.
  • Increased the period we're waiting for the logs from 15 to 20 seconds. Saw an iteration where there were 0 messages in the logs at the point we tried to assert them.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ashovlin ashovlin merged commit c1db17f into dev Nov 28, 2023
5 checks passed
@ashovlin ashovlin deleted the shovlia/lambda-test-fix branch November 28, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants