Split a metric when there're more than 100 data points #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredcnance
approved these changes
Apr 22, 2021
| } | ||
|
|
||
| @Test | ||
| public void testSerializeMetricsWith101DataPoints() throws JsonProcessingException { |
There was a problem hiding this comment.
The main purpose of this test is just to verify that splitting doesn't impact other metric data points added to the context?
There was a problem hiding this comment.
Yes. It also tests that the other metrics should also be included in the first event if there're less than 100 metrics for the first event.
| metrics.put(metric.getName(), metric); | ||
| count++; | ||
| Queue<MetricDefinition> metricDefinitions = | ||
| new LinkedList<>(rootNode.metrics().values()); |
There was a problem hiding this comment.
- My personal preference here is to not use the abstract interface for your local variable. The concrete type (LinkedList) won't be changing and there's not much of a need to limit yourself to only the interface. This is just a style comment not a perf comment (dynamic dispatch won't be necessary in this context) so YMMV.
- This constructor forces enumeration of the set and allocation of a new list. Is this really necessary? It shouldn't be a significant issue, just something to think about.
| Queue<MetricDefinition> metricDefinitions = | ||
| new LinkedList<>(rootNode.metrics().values()); | ||
| while (metricDefinitions.size() > 0) { | ||
| MetricDefinition metric = metricDefinitions.peek(); |
There was a problem hiding this comment.
Do we need peek() if we're going to poll() regardless? Can we just poll() here?
|
Build was throttled by DockerHub rate limit (still need to migrate images over to ECR). Build succeeded on retry. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Metric Value List can go above MetricDefinition limits, causing CW missing metrics
Description of changes:
Split a metric into multiple log events if the metric has more than 100 data points
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.