Skip to content

Conversation

@robin-aws
Copy link
Contributor

Fixes #114

Breaking change since multi-keyrings currently allow a generator to be configured and yet accept encryption materials that already have a plaintext data key defined.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Breaking change since multi-keyrings currently allow a generator to be configured and yet accept encryption materials that already have a plaintext data key defined.
acioc
acioc previously approved these changes Jul 14, 2020
Copy link
Contributor

@acioc acioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There's no "Reference-level Explanation" (not sure if there needs to be), but that's fine since the reference-level is your spec change anyways.

@robin-aws
Copy link
Contributor Author

Looks good! There's no "Reference-level Explanation" (not sure if there needs to be), but that's fine since the reference-level is your spec change anyways.

Yes, in this case there's no detail that would be in one but not the other. Would it be better to label the section as "Guide-level/Reference-level Explanation"?

@acioc
Copy link
Contributor

acioc commented Jul 15, 2020

Looks good! There's no "Reference-level Explanation" (not sure if there needs to be), but that's fine since the reference-level is your spec change anyways.

Yes, in this case there's no detail that would be in one but not the other. Would it be better to label the section as "Guide-level/Reference-level Explanation"?

I personally prefer renaming - I think renaming makes it clear it wasn't forgotten about and reinforces the standard we're trying to follow.

acioc
acioc previously approved these changes Jul 15, 2020
Co-authored-by: Matt Bullock <bullocm@amazon.com>
acioc
acioc previously approved these changes Jul 16, 2020
acioc
acioc previously approved these changes Jul 16, 2020
Copy link
Contributor

@acioc acioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally preferred the wording changes on Security Implications but it's not a blocker.

seebees
seebees previously approved these changes Jul 16, 2020
Co-authored-by: Alex Cioc
@robin-aws robin-aws dismissed stale reviews from seebees and acioc via 0d7b894 July 17, 2020 16:11
@robin-aws robin-aws merged commit 2adf6dc into awslabs:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi keyring generator

4 participants