-
Notifications
You must be signed in to change notification settings - Fork 27
feat!: Require generation in the multi-keyring #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Require generation in the multi-keyring #157
Conversation
Breaking change since multi-keyrings currently allow a generator to be configured and yet accept encryption materials that already have a plaintext data key defined.
acioc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There's no "Reference-level Explanation" (not sure if there needs to be), but that's fine since the reference-level is your spec change anyways.
Yes, in this case there's no detail that would be in one but not the other. Would it be better to label the section as "Guide-level/Reference-level Explanation"? |
I personally prefer renaming - I think renaming makes it clear it wasn't forgotten about and reinforces the standard we're trying to follow. |
Co-authored-by: Matt Bullock <bullocm@amazon.com>
Co-authored-by: Matt Bullock <bullocm@amazon.com>
Co-authored-by: Matt Bullock <bullocm@amazon.com>
acioc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally preferred the wording changes on Security Implications but it's not a blocker.
Co-authored-by: Alex Cioc
Fixes #114
Breaking change since multi-keyrings currently allow a generator to be configured and yet accept encryption materials that already have a plaintext data key defined.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.