bug: fix context cleared prematurely in InvokeStoreSingle with async functions #23
+58
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5aee9a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kuhe
reviewed
Dec 3, 2025
| try { | ||
| return fn(); | ||
| } finally { | ||
| this.currentContext = undefined; |
Contributor
There was a problem hiding this comment.
is there any risk to not freeing this reference?
You could use a weakRef instead
Contributor
Author
There was a problem hiding this comment.
Hey when we run each time we set the context , so it should be fine -> Making it undefined is anyways not going to be helpful
kuhe
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
JS-6397Description of changes:
Fixes a bug in
InvokeStoreSingle.run()where the try-finally block was clearing the context immediately when the function returned a Promise, before async operations completed. This caused the context to become undefined after anyawaitstatement.Changes:
InvokeStoreSingle.run()methodinvoke-store.async-context.spec.tsto verify context persists during async operationsTesting:
awaitstatementsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.