New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing callback in createS3EventSource when notification configuration already exists #211

Open

taoweng100 opened this issue Jul 2, 2020 · 0 comments

taoweng100 commented Jul 2, 2020

common.js/createS3EventSource method:
There is a missing callback in case of notification configuration already exists.

At line 574 of common.js
Could you please change the code from:

if (!configAlreadyExists){
logger.info('Creating notification configuration');

to:

if (configAlreadyExists) {
callback();
} else {
logger.info('Creating notification configuration');

IanMeyers added a commit that referenced this issue


          Fixing #211

d646c2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment