Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove seemingly unnecessary Req -> Parts -> Req conversion #353

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Remove seemingly unnecessary Req -> Parts -> Req conversion #353

merged 1 commit into from
Oct 21, 2021

Conversation

simonvandel
Copy link
Contributor

Note: I haven't tested this on AWS Lambda - just noticed it while reading the source.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@simonvandel
Remove seemingly unnecessary Req -> Parts -> Req conversion
859f40a 
Note: I haven't tested this on AWS Lambda - just noticed it while reading the source.
coltonweaver
coltonweaver approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@coltonweaver coltonweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think this must have been a miss during some prior refactoring. Thanks for pointing it out and fixing! Merging

@coltonweaver coltonweaver merged commit 40e2658 into awslabs:master Oct 21, 2021
@nmoutschen nmoutschen added the 0.5 label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coltonweaver coltonweaver coltonweaver approved these changes

Assignees
No one assigned
Labels
0.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonvandel @coltonweaver @nmoutschen