Expanded README on how to build for Amazon Linux 2 x86 or ARM, includ… #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing instructions for compiling on MacOS
LucioFranco
approved these changes
Nov 2, 2021
rimutaka
reviewed
Nov 3, 2021
README.md
Outdated
| For [a custom runtime](https://docs.aws.amazon.com/lambda/latest/dg/runtimes-custom.html), AWS Lambda looks for an executable called `bootstrap` in the deployment package zip. Rename the generated `basic` executable to `bootstrap` and add it to a zip archive. | ||
|
|
||
| NOTE: Depending on the target you used above, you'll find the provided basic under the corresponding directory. In the following example, we've compiled for x86_64-unknown-linux-gnu. |
There was a problem hiding this comment.
This sentence is a bit confusing in its current form. basic -> basic executable?
There was a problem hiding this comment.
D'oh, that's a good call. I will push a fix for this in a minute.
simonvandel
reviewed
Nov 3, 2021
|
|
||
| **Building for Amazon Linux 2** | ||
|
|
||
| Decide which target you'd like to use. For ARM Lambda Functions you'll want to use `aarch64-unknown-linux-gnu` and for x86 Lambda Functions you'll want to use `x86_64-unknown-linux-gnu`. |
There was a problem hiding this comment.
I'm fairly certain these steps will not work for everyone. AL2 is currently using Glibc 2.26, but if the user's Glibc is newer, this will lead to the lambda crashing on startup. So at the least, I think this should mention that the user should be aware of this
Or am I missing something?
There was a problem hiding this comment.
Hey thanks for the suggestion. I think that's reasonable to add. I'll look into opening another PR tonight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #17
Description of changes:
provided.al2.provided.al2using Docker on MacOS for cross-compilation.By submitting this pull request