Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LambdaRequest lifetime fix #364

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

jelmansouri
Copy link
Contributor

@jelmansouri jelmansouri commented Nov 16, 2021

Description of changes:

Making the LambdaHandler implementation for the adapter more generic over the lifetime of the LambdaRequest, issue encountered in valid code yielding such errors:

= note: `lambda_runtime::Handler<lambda_http::request::LambdaRequest<'1>, lambda_http::response::LambdaResponse>` would have to be implemented for the type `lambda_http::Adapter<'0, grpc::aws_lambda_handler::AwsLambdaHandler<tonic_web::service::GrpcWeb<MultiplexerService>>>`, for any two lifetimes `'0` and 
`'1`...
= note: ...but `lambda_runtime::Handler<lambda_http::request::LambdaRequest<'2>, lambda_http::response::LambdaResponse>` is actually implemented for the type `lambda_http::Adapter<'2, grpc::aws_lambda_handler::AwsLambdaHandler<tonic_web::service::GrpcWeb<MultiplexerService>>>`, for some specific lifetime `'2`

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@coltonweaver
Copy link
Contributor

LGTM, thanks for making this fix!

@coltonweaver coltonweaver merged commit 02a29ff into awslabs:master Nov 16, 2021
@nmoutschen nmoutschen added the 0.5 label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants