Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add integration tests stack #379

Merged
merged 4 commits into from
Dec 17, 2021
Merged

feat: add integration tests stack #379

merged 4 commits into from
Dec 17, 2021

Conversation

nmoutschen
Copy link
Contributor

@nmoutschen nmoutschen commented Dec 11, 2021

Issue #, if available: #377

Description of changes:

Adds a SAM template and AWS Lambda functions to test the crates in this repository on AWS. This allows us to test Rust functions and extensions on both AL1 and AL2. Furthermore, I've included a sample Lambda function in Python so we can test extensions on non-provided runtimes as well.

I'm not a big fan of defining a new crate for those tests, but I don't see a better way to do it at the moment.

  • lambda_runtime with handler_fn
  • lambda_runtime with Handler trait
  • lambda_http with handler
  • lambda_extension with extension_fn
  • lambda_extension with Extension trait

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@coltonweaver
Copy link
Contributor

coltonweaver commented Dec 16, 2021

Just to gather motivations on this - it's essentially setting up an automated way of uploading a set of functions based on this library to actual Lambda and validating that we're able to invoke them successfully? Sort of a pre-PR check? If so, great call. I love this idea.

Edit: Just took a look at your issue assigned to this. Completely agree with you motivation. I think this is a great starting place. Approving. Merge when you want.

@nmoutschen
Copy link
Contributor Author

I've had to disable the multiple_crate_versions clippy lint rule, as time uses itoa-0.4.8 and serde_json uses itoa-1.0.1. This will also fix the issue with #382

@nmoutschen nmoutschen merged commit a7e17ee into master Dec 17, 2021
@nmoutschen nmoutschen deleted the integration-tests branch December 17, 2021 12:44
@nmoutschen nmoutschen added the 0.5 label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants