Skip to content

fix: add support for null/invalid type for multi-value-headers #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mbergkvist
Copy link
Contributor

Issue #, if available: 367

Description of changes:

This adds support for invalid/null value for multi-value headers, defaulting to an empty HeaderMap if need be, increasing resilience if the Lambda function would get an invalid value for multi-value headers.

This is a continuation of the work done by @nmoutschen in #371.

I have also successfully run the test in #367 (comment) locally.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

Copy link
Contributor

@bahildebrand bahildebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bahildebrand bahildebrand merged commit 3a43ed9 into awslabs:master Dec 31, 2021
@mbergkvist mbergkvist deleted the nullable-multi-value-headers branch January 1, 2022 00:53
@nmoutschen nmoutschen added the 0.5 label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants