Wrap incoming extension events in a struct #394
Merged
+32
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Calavera david.calavera@gmail.com
Issue #, if available:
Fixes #392
Description of changes:
This new structure can be used to pass additional information to the extension in each invocation, like the extension id that the Runtime assigns to the extension when it's initialized.
I'm not super keen in cloning the id in every event, but if I start messing with lifetimes, the extension trait becomes much more complicated to implement. I think this is good enough to fix the current issue, and we can iterate on it if it really becomes a problem before making the crate more stable.
By submitting this pull request