Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request query strings #395

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Fix request query strings #395

merged 1 commit into from
Jan 13, 2022

Conversation

calavera
Copy link
Contributor

@calavera calavera commented Jan 9, 2022

Signed-off-by: David Calavera david.calavera@gmail.com

Issue #, if available:

Fixes #109

Description of changes:

  • Add query strings to the request uri. This ensures that we don't mangle information coming into lambda.
  • Fix bug in StrMapIter that ignored multi-value query parameters. Until now, this iterator only looped over the first element of each key, even if the key had multiple values assigned.
  • Add tests to cover these changes.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@calavera
Fix request query strings
e5a8d62 
- Add query strings to the request uri. This ensures that we don't mangle information coming into lambda.
- Fix bug in StrMapIter that ignored multi-value query parameters. Until now, this iterator only looped over the first element of each key, even if the key had multiple values assigned.

Signed-off-by: David Calavera <david.calavera@gmail.com>
bahildebrand
bahildebrand approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@bahildebrand bahildebrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bahildebrand bahildebrand merged commit 917ed63 into awslabs:master Jan 13, 2022
@calavera calavera deleted the fix_query_strings branch January 13, 2022 03:20
@Mdrbhatti Mdrbhatti mentioned this pull request Jan 14, 2022
Closed
@nmoutschen nmoutschen added the 0.5 label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahildebrand bahildebrand bahildebrand approved these changes

Assignees
No one assigned
Labels
0.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query String not present in Request::uri()
3 participants
@calavera @bahildebrand @nmoutschen