Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some missing fields to ApiGateway and ApiGatewayRequestContext #403

Merged
merged 5 commits into from
Jan 19, 2022
Merged

Added some missing fields to ApiGateway and ApiGatewayRequestContext #403

merged 5 commits into from
Jan 19, 2022

Conversation

vascokk
Copy link
Contributor

@vascokk vascokk commented Jan 15, 2022 •
edited
Loading

Issue #, if available:
#307

Description of changes:

Added resource to ApiGateway enum and several fields to ApiGatewayRequestContext.

By submitting this pull request

  • [ x] I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • [ x] I confirm that I've made a best effort attempt to update all relevant documentation.

@vascokk vascokk changed the title Added some missing fields to LambdaRequest and ApiGatewayRequestContext Added some missing fields to ApiGateway { and ApiGatewayRequestContext Jan 15, 2022
@vascokk vascokk changed the title Added some missing fields to ApiGateway { and ApiGatewayRequestContext Added some missing fields to ApiGateway and ApiGatewayRequestContext Jan 15, 2022
calavera
calavera approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmoutschen
nmoutschen suggested changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@nmoutschen nmoutschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me as well, but could you revert the change on .gitignore? Removing build would cause issues when running integration tests on AWS.

@calavera calavera requested a review from nmoutschen January 19, 2022 16:34
nmoutschen
nmoutschen approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@nmoutschen nmoutschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calavera calavera merged commit 70adf9f into awslabs:master Jan 19, 2022
@nmoutschen nmoutschen added the 0.5 label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calavera calavera calavera approved these changes

@nmoutschen nmoutschen nmoutschen approved these changes

Assignees
No one assigned
Labels
0.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vascokk @calavera @nmoutschen