Call handler.poll_ready() before handler.call()
#437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the tower::Service documentation and API contract, `poll_ready` must be called and a `Poll:Ready` must be obtained before invoking `call`
nmoutschen
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this issue while trying to build a Service router, using the
tower::steermodule, which panics ifpoll_readyhas not been called. I was able to work around this issue by implementing the functionality myself, but after digging into the tower Service docs, this appears to be mandated by the API:According to the tower::Service documentation and API contract,
poll_readymust be called and aPoll:Readymust be obtained before invokingcall.Issue #, if available:
Description of changes:
I wrapped the body of the handler invoking function in a call to
poll_ready.See documentation for tower::Service::call
By submitting this pull request