Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda-http): create separate trait for lambda events body #473

Conversation

eduardomourar
Copy link

Issue #, if available: #472

Description of changes:

This will allow the extensions to be used outside the context of a service that passes the Lambda events body. The base trait will accept a default body, and a separate trait will be created specifically for the Lambda events body.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@calavera
Copy link
Contributor

Now that #491 has been merged, I think you're unblocked to work on this.

@calavera
Copy link
Contributor

@eduardomourar let me know if you're interested in getting this change in the next release.

@calavera calavera mentioned this pull request Jul 19, 2022
2 tasks
@calavera
Copy link
Contributor

calavera commented Jul 19, 2022

I'm carrying this over in #503, thanks for your contribution!

@calavera calavera closed this Jul 19, 2022
@calavera calavera reopened this Jul 19, 2022
@calavera
Copy link
Contributor

@eduardomourar let me know if you're interested in making this work, I don't completely understand in which cases this code should raise PayloadError::UnsupportedFormat or return Ok(None).

@hugobast
Copy link
Contributor

@calavera I'll check with Eduardo if he doesn't have time to resume this, I'm interested, but I need a little bit of knowledge sharing first.

@calavera calavera added the contributor/pending-response Waiting for response from a contributor in the thread label Aug 2, 2022
@hugobast
Copy link
Contributor

I'll give an update on this PR today; sorry for the long delay

@hugobast
Copy link
Contributor

@calavera, we can close this, I've played with this PR a bit, and what it offers is nice (i.e. a more permissive trait bound) but not strictly needed for our purpose at Stedi.

Caveat if you'd like this contribution though, I can update the PR and try to answer your questions. LMK

@calavera
Copy link
Contributor

Thanks for looking into it. I'm going to close it if nobody really needs it for now.

@calavera calavera closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor/pending-response Waiting for response from a contributor in the thread
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants