Feature flags for lambda_http #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add feature flags to lambda_http so consumer can decide which service their events come from. This makes compilation much faster when you don't put the same Lambda function behind multiple services. Signed-off-by: David Calavera <david.calavera@gmail.com>
calavera
commented
Jul 2, 2022
| @@ -330,12 +330,6 @@ You can read more about how [cargo lambda start](https://github.com/calavera/car | |||
|
|
|||
| Lambdas can be run and debugged locally using a special [Lambda debug proxy](https://github.com/rimutaka/lambda-debug-proxy) (a non-AWS repo maintained by @rimutaka), which is a Lambda function that forwards incoming requests to one AWS SQS queue and reads responses from another queue. A local proxy running on your development computer reads the queue, calls your Lambda locally and sends back the response. This approach allows debugging of Lambda functions locally while being part of your AWS workflow. The Lambda handler code does not need to be modified between the local and AWS versions. | |||
|
|
|||
| ## `lambda_runtime` | |||
There was a problem hiding this comment.
I've removed this because it's part of an old readme, and we didn't notice until now. It doesn't make sense anymore in this context.
david-perez
approved these changes
Jul 4, 2022
Use the names present in the API GW documentation to differentiate the APIs. Signed-off-by: David Calavera <david.calavera@gmail.com>
|
@david-perez thanks for the feedback. I decided to change the feature names to match how the different APIs are described in the API GW documentation: https://docs.aws.amazon.com/apigateway/latest/developerguide/welcome.html |
Signed-off-by: David Calavera <david.calavera@gmail.com>
bnusunny
requested changes
Jul 5, 2022
README.md
Outdated
| @@ -378,6 +372,30 @@ fn main() -> Result<(), Box<Error>> { | |||
| } | |||
| ``` | |||
|
|
|||
| ## Feature flags in lambda_http | |||
|
|
|||
| `lambda_http` is a wrapper for HTTP events coming from two different services, Amazon Load Balancer (ALB), and Amazon Api Gateway (APIGW). Amazon Api Gateway can also send events from three different endpoints, Proxy V1, Proxy V2, and WebSockets. `lambda_http` transforms events from all these sources into native `http::Request` objects, so you can incorporate Rust HTTP semantics into your Lambda functions. | |||
There was a problem hiding this comment.
lambda_http actually supports three sources: ALB, APIGW, and the new Lambda Function URLs. Lambda Function URLs use the same format as APIGW HTTP API payload format version 2.0. So it works out of box.
There was a problem hiding this comment.
good point, I've updated the readme.
Signed-off-by: David Calavera <david.calavera@gmail.com>
bnusunny
requested changes
Jul 5, 2022
bnusunny
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature flags to lambda_http so consumer can decide which service their events come from. This makes compilation much faster when you don't put the same Lambda function behind multiple services.
I've tested these changes in a simple function behind APIGW, and compilation time for a pre-compiled function drops from 18 seconds to 5 seconds.
Signed-off-by: David Calavera david.calavera@gmail.com
Issue #, if available:
Fixes #481
By submitting this pull request