Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths with spaces in HTTP requests. #516

Merged
merged 2 commits into from
Aug 28, 2022
Merged

Fix paths with spaces in HTTP requests. #516

merged 2 commits into from
Aug 28, 2022

Conversation

calavera
Copy link
Contributor

Encode the characters not allowed in URLs before creating the request.

Signed-off-by: David Calavera david.calavera@gmail.com

Issue #, if available:

Fixes #515

Description of changes:

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

Encode the characters not allowed in URLs before creating the request.

Signed-off-by: David Calavera <david.calavera@gmail.com>
Copy link
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: David Calavera <david.calavera@gmail.com>
@calavera calavera merged commit fd2ea23 into main Aug 28, 2022
@calavera calavera deleted the fix_uri_encoding branch August 28, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lambda_http fails to build request with spaces - http::Error(InvalidUri(InvalidUriChar))
2 participants