Check that lambda_https inner service is ready before calling it

[dcormier]

This allows for service backpressure.

Additionally:

Services are permitted to panic if call is invoked without obtaining Poll::Ready(Ok(())) from poll_ready.

Source

By submitting this pull request

• I confirm that my contribution is made under the terms of the Apache 2.0 license.
• I confirm that I've made a best effort attempt to update all relevant documentation.

[dcormier]

Alternatively, I could tweak the existing http-trait test to include checking that .poll_ready() is properly called.

[dcormier]

lambda_runtime already does this properly, but should a test be added/updated to ensure it continues to do so?

[dcormier]

lambda_extension does not do this properly.

[calavera]

Thanks for opening this PR! Do you mind fixing lambda-extension too? I can do it myself later too.

[dcormier]

I can take a swing at it. Want it in this PR or another one?

[dcormier]

I added it here. I updated the existing integration test to account for this.

I feel like that's a nicer approach. Thoughts on me removing the http-ready integration test I added and making it a part of the preexisting http-trait integration test?

Also: Thoughts on me updating the existing runtime-trait integration tests to ensure lambda_runtime continues to be well behaved?

[calavera]

Thoughts on me removing the http-ready integration test I added and making it a part of the preexisting http-trait integration test?

That sounds like a good idea. We need to look into how we run those directly in PRs, but that's a problem for a different day XD

Thoughts on me updating the existing runtime-trait integration tests to ensure lambda_runtime continues to be well behaved?

Sounds great too 👍

[dcormier]

Alright. That's all done. Thank you for the feedback.