-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invoke example for Windows CMD #604
Conversation
This isn't a Windows-specific issue, but a shell-specific issue. More specifically, CMD. If we do go ahead with this change, however, please update the rest of the examples to follow this convention. |
Done 👍🏽 |
I recommend to keep them seperated, and show examples for both Linux/MacOS and Windows. |
What is the benefit to doing this? Escaping the double quotes should work on most modern shells. |
Linux and MacOs users could use a simpler format. |
How can we do this without cluttering the docs? |
Add one section to talk about it. There is an example in AWS CLI doc. |
Done 👍🏽 Let me know if it's in an appropriate spot. |
I suggest to put this note close to the first apperance of |
Done 👍🏽 |
Description of changes:
Currently the invoke example
cargo lambda invoke rust-lambda --data-ascii '{ "command": "hi" }'
does not work on Windows and returns the following error because of the way that Windows handles single quotes. Trying to invoke the command as shown in the readme returns:error: Found argument 'command:' which wasn't expected, or isn't valid in this context
This change the example invoke command to run for Windows, Mac and Linux.
By submitting this pull request
Edit: Updated the PR name to include CMD