Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added RDS IAM Auth example #908

Merged
merged 4 commits into from
Jul 9, 2024
Merged

added RDS IAM Auth example #908

merged 4 commits into from
Jul 9, 2024

Conversation

Kevinwochan
Copy link
Contributor

✍️ Description of changes:
Added an example of how to use CDK to deploy a rust lambda function that uses IAM Authentication to connect to an RDS instance, feel free to close if out of scope of this repo.

🔏 By submitting this pull request

  • I confirm that I've ran cargo +nightly fmt.
  • I confirm that I've ran cargo clippy --fix.
  • I confirm that I've made a best effort attempt to update all relevant documentation.
  • I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks a lot for providing such a complete example. My only concern is that with the current directory structure, the rust code base won't be tested with changes in the runtime, like all the other examples are.

Do you mind using a similar structure to the one in this example? https://github.com/awslabs/aws-lambda-rust-runtime/tree/main/examples/http-axum

We have a script that builds all the examples in every PR to verify that the code works, but it's being skipped in this one because of the directory structure: https://github.com/awslabs/aws-lambda-rust-runtime/blob/main/examples/check-examples.sh

examples/lambda-rds-iam-auth/lambda/Cargo.toml Outdated Show resolved Hide resolved
@Kevinwochan
Copy link
Contributor Author

When the testing pipeline becomes more flexible, it'd be great to specify a config in the diretory to tell the testing script where the rust project is.

That way we can show what a good directory structure looks like when working with CDK

@calavera
Copy link
Contributor

calavera commented Jul 9, 2024

We're definitely open to improvements on those testing scripts if you want to take a pass in future PRs 🙌

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@calavera calavera merged commit 4b5ffc8 into awslabs:main Jul 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants