fix: override user-set x-amzn-{lambda,request}-context headers
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluxth
force-pushed
the
context-headers-prune
branch
3 times, most recently
from
c625a3a to
b4bf219
Compare
|
Thanks for this PR. This is a validate concern. However, I would recommend a different implementation: change |
Currently, when a client sets their own
`x-amzn-{lambda,request}-context` headers, they will be included in the
request to the app server.
This request to the lambda with the adapter installed:
```
$ curl -H "x-amzn-request-context: boom" http://localhost:8000
```
Will result in this request from the adapter to the app server:
```
GET / HTTP/1.1
[...]
x-amzn-request-context: boom
x-amzn-request-context: [json context from adapter]
x-amzn-lambda-context: [json context from adapter]
[...]
```
Many implementations of web frameworks will take the *first* header when
you access a header key.
For example, Starlette/FastAPI does this:
https://github.com/encode/starlette/blob/ad02ee6336faadadf97e0c79dd3a91759f1f32a7/starlette/datastructures.py#L562-L567
This patch overrides every user-set `x-amzn-{request,lambda}-context`
headers from the request by JSON context headers from the adapter.
Signed-off-by: Thitat Auareesuksakul <thitat@flux.ci>
fluxth
force-pushed
the
context-headers-prune
branch
from
b4bf219 to
ce3c909
Compare
fluxth
changed the title
x-amzn-*-context headersx-amzn-{lambda,request}-context headers
|
@fluxth Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, when a client sets their own
x-amzn-{lambda,request}-contextheaders, they will be included in the request to the app server.This request to the lambda with the adapter installed:
Will result in this request from the adapter to the app server:
Many implementations of web frameworks will take the first header when you access a header key.
For example, Starlette/FastAPI does this:
https://github.com/encode/starlette/blob/ad02ee6336faadadf97e0c79dd3a91759f1f32a7/starlette/datastructures.py#L562-L567
This patch overrides every user-set
x-amzn-{request,lambda}-contextheaders from the request by JSON context headers from the adapter.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.