add authorization_source feature #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmokmss
commented
Jul 15, 2024
src/lib.rs
Outdated
|
|
||
| if !self.authorization_source.is_empty() && req_headers.contains_key(&self.authorization_source) { | ||
| let original = req_headers.remove(&self.authorization_source).unwrap(); | ||
| req_headers.insert("authorization", original); |
There was a problem hiding this comment.
HeaderMap is case-insensitive: https://docs.rs/http/latest/http/header/index.html
Header names are normalized to lower case.
so we just use authorization here.
tmokmss
commented
Jul 15, 2024
| // Start app server | ||
| let app_server = MockServer::start(); | ||
| let hello = app_server.mock(|when, then| { | ||
| when.method(GET).path("/hello").header_exists("Authorization"); |
There was a problem hiding this comment.
header_exists makes requests fail if it does not contain Authorization header. https://docs.rs/httpmock/latest/httpmock/struct.When.html#method.header_exists
This effectively validates the authorization_source behavior.
bnusunny
requested changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#477
Description of changes:
Added
AWS_LWA_AUTHORIZATION_SOURCEoption to rename a specifed header name toAuthorization. Details are in the linked issue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.