fix: add support for china clusters endpoints in failover #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
reviewed
Dec 13, 2023
| @@ -123,18 +123,37 @@ public class FailoverConnectionPlugin implements IConnectionPlugin { | |||
| private final PropertySet propertySet; | |||
| private final IConnectionPlugin nextPlugin; | |||
| private final Log logger; | |||
|
|
|||
| // patterns | |||
| private final Pattern auroraDnsPattern = | |||
There was a problem hiding this comment.
Looks like these Regex patterns and methods are already implemented in RdsUtils, but FailoverConnectionPlugin is calling the outdated methods in this file instead. Should we centralize these methods?
|
Closing this PR as the changes have been merged in #543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: add support for china clusters endpoints in failover
Additional Reviewers
@sergiyv-improving
@karenc-bq