Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix accidental inclusion of expression attribute members in high-level DynamoDB Mapper requests #1432

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

ianbotsf
Copy link
Contributor

@ianbotsf ianbotsf commented Oct 4, 2024

Issue #

Related to #472

Description of changes

This change removes expressionAttributeNames and expressionAttributeValues from the high-level mapper request types. The equivalent low-level members are automatically filled by ParameterizingExpressionVisitor and were totally ignored in high-level requests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf requested a review from a team as a code owner October 4, 2024 23:38
Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

github-actions bot commented Oct 4, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@ianbotsf ianbotsf merged commit 9d79622 into feat-ddb-mapper Oct 5, 2024
11 checks passed
@ianbotsf ianbotsf deleted the fix-expression-arguments branch October 5, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants