-
Notifications
You must be signed in to change notification settings - Fork 13
Release: Amazon Transcribe Streaming Client #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
clients/aws-sdk-transcribe-streaming/src/aws_sdk_transcribe_streaming/client.py
Show resolved
Hide resolved
clients/aws-sdk-transcribe-streaming/src/aws_sdk_transcribe_streaming/client.py
Show resolved
Hide resolved
clients/aws-sdk-transcribe-streaming/src/aws_sdk_transcribe_streaming/client.py
Outdated
Show resolved
Hide resolved
| * ``sample-rate`` | ||
|
|
||
| For more information on streaming with Amazon Transcribe, see `Transcribing streaming audio <https://docs.aws.amazon.com/transcribe/latest/dg/streaming.html>`_ | ||
| . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This newline also seems potentially wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, our code-generator chooses to go over the line limit so the link isn't broken. It then decides to put all remaining characters on a newline. We can potentially special case the .. But that can probably be addressed with smithy-lang/smithy-python#571
clients/aws-sdk-transcribe-streaming/src/aws_sdk_transcribe_streaming/config.py
Outdated
Show resolved
Hide resolved
| class RequestTestHTTPClient: | ||
| """An asynchronous HTTP client solely for testing purposes.""" | ||
|
|
||
| def __init__(self, *, client_config: HTTPClientConfiguration | None = None): | ||
| self._client_config = client_config | ||
|
|
||
| async def send( | ||
| self, | ||
| request: HTTPRequest, | ||
| *, | ||
| request_config: HTTPRequestConfiguration | None = None, | ||
| ) -> HTTPResponse: | ||
| # Raise the exception with the request object to bypass actual request handling | ||
| raise TestHttpServiceError(request) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we generate this? If not, we should be using the fixtures from @alexgromero's PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is generated. I asked Jordon about this file and whether it was intentional to generate this in codegen/protocol-test and in the generated clients. He mentioned "It's intentional in that any service can have protocol tests. But the actual file could be omitted if there’s no trait"
This PR adds a new client for the Amazon Transcribe Streaming Service.
Summary
Add support for the Amazon Transcribe Streaming service by adding the latest Smithy model and code-generating a new client package (
aws-sdk-transcribe-streaming).Changes
transcribe-streaming.jsonmodel definition tocodegen/aws-models/Testing
cd clients/aws-sdk-transcribe-streaminguv venv -p 3.14source .venv/bin/activatesounddevice:uv pip install . sounddeviceEnvironmentCredentialsResolver)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.