Add integration tests for Transcribe Streaming #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
suggested changes
Dec 2, 2025
Contributor
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Few minor comments but otherwise looks like we're all set. Thanks @alexgromero!
clients/aws-sdk-transcribe-streaming/tests/integration/test_bidirectional_streaming.py
Outdated
Show resolved
Hide resolved
clients/aws-sdk-transcribe-streaming/tests/integration/test_bidirectional_streaming.py
Show resolved
Hide resolved
clients/aws-sdk-transcribe-streaming/tests/integration/test_non_streaming.py
Show resolved
Hide resolved
clients/aws-sdk-transcribe-streaming/tests/integration/test_non_streaming.py
Outdated
Show resolved
Hide resolved
clients/aws-sdk-transcribe-streaming/tests/integration/test_non_streaming.py
Show resolved
Hide resolved
…directional_streaming.py Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
nateprewitt
reviewed
Dec 3, 2025
Contributor
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Last minor comment, otherwise we're ready to merge I think.
Comment on lines
48
to
49
| assert role_arn, "HEALTHSCRIBE_ROLE_ARN environment variable not set" | ||
| assert s3_bucket, "HEALTHSCRIBE_S3_BUCKET environment variable not set" |
Contributor
There was a problem hiding this comment.
We can definitely do this approach, what I was asking about earlier was using pytest.fail instead of pytest.skip though. The explicit test failure let's us surface the configuration issue in one message rather than having to run the script multiple times for the asserts.
The asserts are there to enforce something about the test rather than setup ideally.
Contributor
Author
There was a problem hiding this comment.
Ahh got it! Updated in latest revision.
nateprewitt
added a commit
that referenced
this pull request
Jan 2, 2026
* Add integration tests for Bedrock Runtime (#37) * Add integration tests for Transcribe Streaming (#38) * Update integration tests to use the latest Amazon Nova 2 models (#39) * Update to latest bedrock-runtime model * Release: aws-sdk-bedrock-runtime-0.3.0 * Release: AWS SDK Transcribe Streaming 0.3.0 * Release: AWS SDK Sagemaker Runtime HTTP2 0.3.0 * Release: aws-sdk-python 0.3.0 --------- Co-authored-by: Alessandra Romero <24320222+alexgromero@users.noreply.github.com> Co-authored-by: jonathan343 <43360731+jonathan343@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds comprehensive integration tests for Amazon Transcribe Streaming client covering the following streaming patterns:
get_medical_scribe_stream(requires setup)start_stream_transcriptionNon-streaming Test Setup:
The
get_medical_scribe_streamtest requires AWS resources (IAM role + S3 bucket). A setup script is included attests/setup_resources.pythat creates these resources. The test fails if the required environment variables (HEALTHSCRIBE_ROLE_ARNandHEALTHSCRIBE_S3_BUCKET) are not set.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.