Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide sigv4 apply_to_request_http1x function #1041

Closed
2 tasks
mattklein123 opened this issue Jan 13, 2024 · 3 comments
Closed
2 tasks

Provide sigv4 apply_to_request_http1x function #1041

mattklein123 opened this issue Jan 13, 2024 · 3 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@mattklein123
Copy link

Describe the feature

Please provide a version of https://docs.rs/aws-sigv4/latest/aws_sigv4/http_request/struct.SigningInstructions.html#method.apply_to_request_http0x against the http 1.x crate.

I would do this PR myself and submit but I'm a little hazy on how you all want to handle the features that gate 0.x and 1.x moving forward in the future. Thank you!

Use Case

Need to call this function with http 1.0 requests. For now I just copied the function but it would be nice to have it included.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

A note for the community

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment
@mattklein123 mattklein123 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 13, 2024
@ymwjbxxq ymwjbxxq mentioned this issue Jan 14, 2024
Closed
@rcoh rcoh mentioned this issue Jan 14, 2024
Closed
@rcoh
Copy link
Contributor

rcoh commented Jan 16, 2024

yeah I can add this this morning. Can you remind me of your use cases for needing to sign requests directly?

@mattklein123
Copy link
Author

yeah I can add this this morning. Can you remind me of your use cases for needing to sign requests directly?

Amazon Managed Prometheus.

@rcoh rcoh mentioned this issue Jan 16, 2024
Merged
2 tasks
github-merge-queue bot pushed a commit to smithy-lang/smithy-rs that referenced this issue Jan 17, 2024
@rcoh
Update sigv4 to allow applying signature to http1x URIs (#3366)
e9abec6 
## Motivation and Context
- awslabs/aws-sdk-rust#1041

## Description
Enable signing Http 1x requests.

## Testing
Unit tests

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@jmklix jmklix added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Jan 19, 2024
@rcoh rcoh added the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Jan 24, 2024
@rcoh rcoh closed this as completed Feb 12, 2024
@github-actions GitHub Actions
Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@mxfactorial mxfactorial mentioned this issue Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rcoh @jmklix @mattklein123