Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable StalledStreamProtection for Transcribe #1181

Closed
MathieuDuponchelle opened this issue Aug 30, 2024 · 5 comments
Closed

Disable StalledStreamProtection for Transcribe #1181

MathieuDuponchelle opened this issue Aug 30, 2024 · 5 comments
Assignees
@Velfi
Labels
bug This issue is a bug.

Comments

@MathieuDuponchelle
Copy link

MathieuDuponchelle commented Aug 30, 2024 •
edited
Loading

Describe the bug

Similar to #1166 , after updating to a recent version we encounter spurious throughput errors using the Transcribe service:

0:00:49.226407000  9616 000001CABEECF030 ERROR          awstranscribe net\aws\src\transcriber\transcribe.rs:192:gstaws::transcriber::transcribe::TranscriberStream::next::{{closure}}::{{closure}}:<transcriber> Transcribe ws stream error: dispatch failure: Error - DispatchFailure(DispatchFailure { source: ConnectorError { kind: Io, source: ThroughputBelowMinimum { expected: Throughput { bytes_read: 1, per_time_elapsed: 1s }, actual: Throughput { bytes_read: 0, per_time_elapsed: 1s } }, connection: Unknown } })

Expected Behavior

The transcribe service should not fail because of stalled stream protection

Current Behavior

The transcribe service fails because of stalled streams protection

Reproduction Steps

We reproduce the issue with the GStreamer wrapper, we don't have a standalone program to demonstrate the issue

Possible Solution

No response

Additional Information/Context

No response

Version

PS T:\code\gst-plugins-rs> cargo tree | grep aws-
    Skipping git submodule `https://github.com/gtk-rs/gir` due to update strategy in .gitmodules
    Skipping git submodule `https://github.com/gtk-rs/gir-files` due to update strategy in .gitmodules
    Skipping git submodule `https://gitlab.freedesktop.org/gstreamer/gir-files-rs.git` due to update strategy in .gitmodules
    Skipping git submodule `https://github.com/gtk-rs/gir` due to update strategy in .gitmodules
    Skipping git submodule `https://github.com/gtk-rs/gir-files` due to update strategy in .gitmodules
    Skipping git submodule `https://github.com/gtk-rs/gir` due to update strategy in .gitmodules
    Skipping git submodule `https://github.com/gtk-rs/gir-files` due to update strategy in .gitmodules
????????? aws-config v1.1.10
???   ????????? aws-credential-types v1.2.0
???   ???   ????????? aws-smithy-async v1.2.1
???   ???   ????????? aws-smithy-runtime-api v1.4.0
???   ???   ???   ????????? aws-smithy-async v1.2.1 (*)
???   ???   ???   ????????? aws-smithy-types v1.1.8
???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ????????? aws-runtime v1.2.0
???   ???   ????????? aws-credential-types v1.2.0 (*)
???   ???   ????????? aws-sigv4 v1.2.1
???   ???   ???   ????????? aws-credential-types v1.2.0 (*)
???   ???   ???   ????????? aws-smithy-eventstream v0.60.4
???   ???   ???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ???   ???   ????????? aws-smithy-http v0.60.8
???   ???   ???   ???   ????????? aws-smithy-eventstream v0.60.4 (*)
???   ???   ???   ???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ???   ???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ???   ???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ???   ????????? aws-smithy-async v1.2.1 (*)
???   ???   ????????? aws-smithy-eventstream v0.60.4 (*)
???   ???   ????????? aws-smithy-http v0.60.8 (*)
???   ???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ???   ????????? aws-types v1.2.0
???   ???   ???   ????????? aws-credential-types v1.2.0 (*)
???   ???   ???   ????????? aws-smithy-async v1.2.1 (*)
???   ???   ???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ????????? aws-sdk-sso v1.19.0
???   ???   ????????? aws-credential-types v1.2.0 (*)
???   ???   ????????? aws-runtime v1.2.0 (*)
???   ???   ????????? aws-smithy-async v1.2.1 (*)
???   ???   ????????? aws-smithy-http v0.60.8 (*)
???   ???   ????????? aws-smithy-json v0.60.7
???   ???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ???   ????????? aws-smithy-runtime v1.2.1
???   ???   ???   ????????? aws-smithy-async v1.2.1 (*)
???   ???   ???   ????????? aws-smithy-http v0.60.8 (*)
???   ???   ???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ???   ????????? aws-types v1.2.0 (*)
???   ????????? aws-sdk-ssooidc v1.19.0
???   ???   ????????? aws-credential-types v1.2.0 (*)
???   ???   ????????? aws-runtime v1.2.0 (*)
???   ???   ????????? aws-smithy-async v1.2.1 (*)
???   ???   ????????? aws-smithy-http v0.60.8 (*)
???   ???   ????????? aws-smithy-json v0.60.7 (*)
???   ???   ????????? aws-smithy-runtime v1.2.1 (*)
???   ???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ???   ????????? aws-types v1.2.0 (*)
???   ????????? aws-sdk-sts v1.19.0
???   ???   ????????? aws-credential-types v1.2.0 (*)
???   ???   ????????? aws-runtime v1.2.0 (*)
???   ???   ????????? aws-smithy-async v1.2.1 (*)
???   ???   ????????? aws-smithy-http v0.60.8 (*)
???   ???   ????????? aws-smithy-json v0.60.7 (*)
???   ???   ????????? aws-smithy-query v0.60.7
???   ???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ???   ????????? aws-smithy-runtime v1.2.1 (*)
???   ???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ???   ????????? aws-smithy-xml v0.60.8
???   ???   ????????? aws-types v1.2.0 (*)
???   ????????? aws-smithy-async v1.2.1 (*)
???   ????????? aws-smithy-http v0.60.8 (*)
???   ????????? aws-smithy-json v0.60.7 (*)
???   ????????? aws-smithy-runtime v1.2.1 (*)
???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ????????? aws-smithy-types v1.1.8 (*)
???   ????????? aws-types v1.2.0 (*)
????????? aws-credential-types v1.2.0 (*)
????????? aws-sdk-s3 v1.22.0
???   ????????? aws-credential-types v1.2.0 (*)
???   ????????? aws-runtime v1.2.0 (*)
???   ????????? aws-sigv4 v1.2.1 (*)
???   ????????? aws-smithy-async v1.2.1 (*)
???   ????????? aws-smithy-checksums v0.60.7
???   ???   ????????? aws-smithy-http v0.60.8 (*)
???   ???   ????????? aws-smithy-types v1.1.8 (*)
???   ????????? aws-smithy-eventstream v0.60.4 (*)
???   ????????? aws-smithy-http v0.60.8 (*)
???   ????????? aws-smithy-json v0.60.7 (*)
???   ????????? aws-smithy-runtime v1.2.1 (*)
???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ????????? aws-smithy-types v1.1.8 (*)
???   ????????? aws-smithy-xml v0.60.8 (*)
???   ????????? aws-types v1.2.0 (*)
????????? aws-sdk-transcribestreaming v1.19.0
???   ????????? aws-credential-types v1.2.0 (*)
???   ????????? aws-runtime v1.2.0 (*)
???   ????????? aws-sigv4 v1.2.1 (*)
???   ????????? aws-smithy-async v1.2.1 (*)
???   ????????? aws-smithy-eventstream v0.60.4 (*)
???   ????????? aws-smithy-http v0.60.8 (*)
???   ????????? aws-smithy-json v0.60.7 (*)
???   ????????? aws-smithy-runtime v1.2.1 (*)
???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ????????? aws-smithy-types v1.1.8 (*)
???   ????????? aws-types v1.2.0 (*)
????????? aws-sdk-translate v1.19.0
???   ????????? aws-credential-types v1.2.0 (*)
???   ????????? aws-runtime v1.2.0 (*)
???   ????????? aws-smithy-async v1.2.1 (*)
???   ????????? aws-smithy-http v0.60.8 (*)
???   ????????? aws-smithy-json v0.60.7 (*)
???   ????????? aws-smithy-runtime v1.2.1 (*)
???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ????????? aws-smithy-types v1.1.8 (*)
???   ????????? aws-types v1.2.0 (*)
????????? aws-types v1.2.0 (*)
????????? aws-config v1.1.10 (*)
????????? aws-credential-types v1.2.0 (*)
????????? aws-sdk-kinesisvideo v1.19.0
???   ????????? aws-credential-types v1.2.0 (*)
???   ????????? aws-runtime v1.2.0 (*)
???   ????????? aws-smithy-async v1.2.1 (*)
???   ????????? aws-smithy-http v0.60.8 (*)
???   ????????? aws-smithy-json v0.60.7 (*)
???   ????????? aws-smithy-runtime v1.2.1 (*)
???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ????????? aws-smithy-types v1.1.8 (*)
???   ????????? aws-types v1.2.0 (*)
????????? aws-sdk-kinesisvideosignaling v1.19.0
???   ????????? aws-credential-types v1.2.0 (*)
???   ????????? aws-runtime v1.2.0 (*)
???   ????????? aws-smithy-async v1.2.1 (*)
???   ????????? aws-smithy-http v0.60.8 (*)
???   ????????? aws-smithy-json v0.60.7 (*)
???   ????????? aws-smithy-runtime v1.2.1 (*)
???   ????????? aws-smithy-runtime-api v1.4.0 (*)
???   ????????? aws-smithy-types v1.1.8 (*)
???   ????????? aws-types v1.2.0 (*)
????????? aws-sigv4 v1.2.1 (*)
????????? aws-smithy-http v0.60.8 (*)
????????? aws-smithy-types v1.1.8 (*)
????????? aws-types v1.2.0 (*)

Environment details (OS name and version, etc.)

Windows

Logs

No response
@MathieuDuponchelle MathieuDuponchelle added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 30, 2024
@Velfi Velfi removed the needs-triage This issue or PR still needs to be triaged. label Aug 30, 2024
@Velfi Velfi self-assigned this Aug 30, 2024
@Velfi
Copy link
Contributor

Velfi commented Aug 30, 2024 •
edited
Loading

What operation is failing? For now, you can disable stalled stream protection by setting a config value.

@Velfi Velfi added the response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 7 days. label Aug 30, 2024
@MathieuDuponchelle
Copy link
Author

This operation fails: https://docs.rs/aws-sdk-transcribestreaming/latest/aws_sdk_transcribestreaming/operation/start_stream_transcription/index.html .

We have indeed disabled the protection now, but I figured I would file an issue anyway because I don't think having it on by default is sensible in this particular case :)

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to 'closing-soon' in 7 days. label Aug 31, 2024
@MathieuDuponchelle
Copy link
Author

ping @Velfi :)

@landonxjames landonxjames mentioned this issue Sep 15, 2024
Merged
1 task
github-merge-queue bot pushed a commit to smithy-lang/smithy-rs that referenced this issue Sep 16, 2024
@landonxjames
Remove stalled stream protection from transcribestreaming (#3831)
d288ef9 
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here -->
awslabs/aws-sdk-rust#1181

## Checklist
- [x] For changes to the AWS SDK, generated SDK code, or SDK runtime
crates, I have created a changelog entry Markdown file in the
`.changelog` directory, specifying "aws-sdk-rust" in the `applies_to`
key.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
aws-sdk-rust-ci pushed a commit that referenced this issue Sep 17, 2024
@landonxjames @aws-sdk-rust-ci
[smithy-rs] Remove stalled stream protection from transcribestreaming…
494ca1a 
… (#3831)

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here -->
#1181

## Checklist
- [x] For changes to the AWS SDK, generated SDK code, or SDK runtime
crates, I have created a changelog entry Markdown file in the
`.changelog` directory, specifying "aws-sdk-rust" in the `applies_to`
key.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@ysaito1001
Copy link
Collaborator

ysaito1001 commented Sep 18, 2024 •
edited
Loading

Fix released on 9/17/2024. Let us know if the issue persists even after you have upgraded to aws-sdk-transcribestreaming 1.43.0 or after.

@github-actions GitHub Actions
Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Velfi Velfi

Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MathieuDuponchelle @Velfi @ysaito1001