Provide endpoint_url via env var or profile #1109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exoego
changed the title
|
Hi @exoego, thank you for taking time to make code changes and submitting your PR (arigatou gozaimasu)! The requested functionality was recently implemented (PR), and we are planning to get the release out this week. Also, for your future reference, if you wish to contribute, kindly submit your PR to smithy-rs instead of this repository (as described in CONTRIBUTING). |
|
The feature has just been released (release notes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #932
Ref. https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html
Note
This PR adds support for
AWS_ENDPOINT_URLAWS_IGNORE_CONFIGURED_ENDPOINT_URLSwhich is useful for testing implementation on AWS emulators like LocalStack.
This PR does not add support for
AWS_ENDPOINT_URL_<SERVICE>since it will be a huge change.
That will be implemented in subsequent PRs.