Emit CloudWatch metrics from the canary runner #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
reviewed
Jan 7, 2022
Comment on lines
+94
to
+97
| request_builder | ||
| .send() | ||
| .await | ||
| .context("failed to emit metrics")?; |
Contributor
There was a problem hiding this comment.
is there some sort of fallback where this can fail even if we somehow bricked the cloudwatch client?
Contributor
Author
There was a problem hiding this comment.
My thought was that once we have the canary running on a regular cadence, we can set up an alarm that goes off if it hasn't logged a metric in the last 25 or so hours.
rcoh
pushed a commit
that referenced
this pull request
Jan 11, 2022
Velfi
pushed a commit
that referenced
this pull request
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds success, failure, and timing metrics to the canary runner.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.