Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use Smithy 1.52.1 #1802

Merged
merged 3 commits into from
Oct 24, 2024
Merged

chore: Use Smithy 1.52.1 #1802

merged 3 commits into from
Oct 24, 2024

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Oct 23, 2024 •
edited
Loading

Description of changes

  • Require Smithy 1.52.1.
  • Re-enable the NestedXmlMapWithXmlNameSerializes test, which is fixed in this release.
  • Smithy 1.52.1 adds a new validator here which flags shapes that aren't attached to a service. The removeUnusedShapes transform is added to the build command for Smithy protocol test generation so that these shapes are stripped & the validation is not triggered.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins requested a review from sichanyoo October 24, 2024 16:12
@jbelkins jbelkins merged commit ac4415d into main Oct 24, 2024
29 checks passed
@jbelkins jbelkins deleted the jbe/smithy_1_52_1 branch October 24, 2024 20:31
jbelkins added a commit that referenced this pull request Oct 28, 2024
@jbelkins
chore: Use Smithy 1.52.1 (#1802)
28ac842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sichanyoo sichanyoo sichanyoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbelkins @sichanyoo