Fix: content-length was not matching the body after an array to string conversion #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this causing an issue? Is this the right thing to do? API Gateway converts it again anyway, and at that point the content-length will not match the content that gets returned to the client. |
|
@brettstack It is causing issues if you run your code locally using https://github.com/awslabs/aws-sam-local I could not find a good workaround. What do you think? |
|
Sounds like a SAM Local issue. Do they have binary support? If they don't then it will just result in a base64 string being returned, right? |
|
Merged in #147 which fixes this. Thanks! |
OneDev0411
added a commit
to OneDev0411/serverless-express
that referenced
this pull request
Mar 16, 2023
<a name="3.3.5"></a> ## [3.3.5](CodeGenieApp/serverless-express@v3.3.4...v3.3.5) (2018-08-20) ### Bug Fixes * apply Content-Length header when missing ([b0927b8](CodeGenieApp/serverless-express@b0927b8)), closes [#147](CodeGenieApp/serverless-express#147) [#106](CodeGenieApp/serverless-express#106) [#130](CodeGenieApp/serverless-express#130) * apply Content-Length header when missing ([#175](CodeGenieApp/serverless-express#175)) ([c2f416b](CodeGenieApp/serverless-express@c2f416b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #129
Description of changes:
Recalculate the body length and set the content-length with this new value.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.