Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminate using tags #37

Merged
merged 2 commits into from
Feb 5, 2021
Merged

terminate using tags #37

merged 2 commits into from
Feb 5, 2021

Conversation

brycahta
Copy link
Contributor

@brycahta brycahta commented Feb 2, 2021

Issue #, if available:

  • N/A

Description of changes:

  • Users can now terminate instances by tag key:pair value(s)! 🎉
  • simple-ec2 terminate --tags tag1=val1 --> terminates ALL instances containing tag1:val1 tags
  • simple-ec2 terminate -n instanceId1,instanceId2 --tags tag1=val1 --> terminates instances at the intersection of instanceId and tags
  • Updated tests + mocks

Testing:

  • Tested both use cases locally (with and without instanceId) and saw expected functionality
  • make unit-test pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta brycahta requested a review from pdk27 February 2, 2021 22:18
pdk27
pdk27 suggested changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@pdk27 pdk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions / comments.

cmd/terminate.go Outdated Show resolved Hide resolved
cmd/terminate.go Show resolved Hide resolved
cmd/terminate.go Show resolved Hide resolved
pkg/ec2helper/ec2helper_test.go Show resolved Hide resolved
pkg/ec2helper/ec2helper_test.go Outdated Show resolved Hide resolved
pkg/ec2helper/ec2helper_test.go Outdated Show resolved Hide resolved
pkg/tag/tag.go Show resolved Hide resolved
test/testhelper/ec2helper_mock.go Show resolved Hide resolved
cmd/terminate.go Show resolved Hide resolved
cmd/terminate.go Show resolved Hide resolved
@pdk27
Copy link
Contributor

pdk27 commented Feb 5, 2021

LGTM. Thanks for making the changes.

@pdk27 pdk27 merged commit 9811ca6 into awslabs:main Feb 5, 2021
@ec2-bot ec2-bot mentioned this pull request Feb 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdk27 pdk27 pdk27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brycahta @pdk27