Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix launch without region flag #39

Merged
merged 1 commit into from
Feb 8, 2021
Merged

fix launch without region flag #39

merged 1 commit into from
Feb 8, 2021

Conversation

brycahta
Copy link
Contributor

@brycahta brycahta commented Feb 8, 2021

Issue #, if available:

  • N/A, noticed some minor issues

Description of changes:

  1. ReadMe says >simple-ec2 launch is valid; however, the current code will always set region to be "" and the program will exit
  2. Confirmation prompt wasn't formatted properly

Testing:

  • make unit-test

Confirmation prompt Before/After:

  • Before: Please confirm if you would like to launch instance with following options: :
  • After: Please confirm if you would like to launch instance with following options:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta brycahta requested a review from cjerad February 8, 2021 19:18
Copy link

@cjerad cjerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants