Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance release targets #43

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Enhance release targets #43

merged 2 commits into from
Feb 9, 2021

Conversation

brycahta
Copy link
Contributor

@brycahta brycahta commented Feb 9, 2021

Issue #, if available: N/A

Description of changes:

  • Adds error messaging for upload script
  • Updates version replacement by escaping "."
  • There's no need for ec2-bot to post the auto-created PR for release, therefore removing (hence the collabs)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta brycahta requested a review from bwagner5 February 9, 2021 17:25
bwagner5
bwagner5 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@brycahta brycahta merged commit bffc8de into awslabs:main Feb 9, 2021
@brycahta brycahta deleted the release-fixn branch February 9, 2021 21:04
@ec2-bot ec2-bot mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brycahta @bwagner5 @ec2-bot