Update go version and specify some library versions in Dockerfiles #57
Conversation
This will prevent build failures related to deprecation of `go get` in go 1.18.
test/go-report-card-test/Dockerfile
Outdated
|
|
||
| WORKDIR /app | ||
|
|
||
| ARG GO111MODULE=auto |
There was a problem hiding this comment.
This is a bit of a hack, because it doesn't address go get being deprecated, and it will also modify go.mod and go.sum if a humans runs it locally. I'm still trying to figure out how to get line 7 to work (make install inside the goreportcard repo after download) with go install instead of go get. But in the mean time, better to have a working build than to have this 100% perfect.
There was a problem hiding this comment.
Let's just remove go-report-card-test altogether as I don't think we get much value out of it anymore. NTH has been without it for awhile and I'll submit the PR to remove for AEMM shortly
test/go-report-card-test/Dockerfile
Outdated
|
|
||
| WORKDIR /app | ||
|
|
||
| ARG GO111MODULE=auto |
There was a problem hiding this comment.
Let's just remove go-report-card-test altogether as I don't think we get much value out of it anymore. NTH has been without it for awhile and I'll submit the PR to remove for AEMM shortly
This will prevent build failures related to deprecation of
go getin go 1.18.Issue #, if available: N/A
Description of changes:
Fix some build failures, similar to this PR in another repo that has a similar structure: aws/aws-node-termination-handler#605
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.