Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show AMI images based on the type of ec2 instance type chosen #60

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

icarthick
Copy link
Contributor

Issue #, if available:
#52

Description of changes:
Select images based on the architecture of ec2 instance to be used

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@icarthick icarthick requested a review from a team as a code owner April 1, 2022 16:57
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested locally and verified that it works as expected

@snay2 snay2 merged commit adda1b2 into awslabs:main Apr 5, 2022
snay2 added a commit to snay2/aws-simple-ec2-cli that referenced this pull request Jun 13, 2022
Hardcode `x86_64` architecture for these calls in unit tests
@snay2 snay2 mentioned this pull request Jun 13, 2022
snay2 added a commit that referenced this pull request Jun 14, 2022
* Fix unit test after table formatting change in #61

* Add note about running CFN tests from VSCode

* Fix unit test for tag date/time formatting change in #73

* Fix unit tests that rely on image API call, after change in #60

Hardcode `x86_64` architecture for these calls in unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants