Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End-to-end tests #68

Merged
merged 6 commits into from
May 16, 2022
Merged

End-to-end tests #68

merged 6 commits into from
May 16, 2022

Conversation

snay2
Copy link
Contributor

@snay2 snay2 commented May 12, 2022

Issue #, if available: N/A

Description of changes:

Get the end-to-end tests working better.

  • Pass a full detailedConfig to LaunchInstance() to fix nil pointer error
  • Validate that the properties of the actually launched instance match the properties we requested
  • Run gofmt to fix whitespace in all files

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@snay2 snay2 requested a review from a team as a code owner May 12, 2022 22:00
cjerad
cjerad approved these changes May 16, 2022
View reviewed changes
Copy link

@cjerad cjerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@snay2 snay2 merged commit 5e01308 into awslabs:main May 16, 2022
@snay2 snay2 deleted the tests branch May 16, 2022 19:18
@ec2-bot ec2-bot mentioned this pull request May 31, 2022
Closed
@LikithaVemulapalli LikithaVemulapalli mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjerad cjerad cjerad approved these changes

Assignees

@cjerad cjerad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snay2 @cjerad