Unique SSH security groups #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2022 15:34
…rors when creating multiple
…rors when creating multiple
|
Can you update the description with a before/after example? I want to verify that appending a raw UUID will satisfy the naming requirements Bryan described. |
added 2 commits
June 24, 2022 11:54
…rder to avoid an error. Also removed the ability to add all SGs at once to also avoid this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #78
Description of changes: Fixed bug where SSH security group used static group name, causing errors when creating multiple ssh security groups. Set limit of 5 on how many security groups can be added to a VPC in order to avoid an error.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Security Group Name Before: simple-ec2 SSH
Security Group Name After: simple-ec2 SSH-d5d9c678-7afb-4fb8-b734-d8bef1c4216d