Fix Homebrew sync script #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repo uses different names for the binary and for the brew formula, unlike our other repos. Introduced a new optional parameter to the homebrew sync script to allow specifying a formula name. If not supplied, it will default to the binary name, keeping the same behavior as before. Some work remains to get this on par with instance-selector (such as adding support for Mac M1 builds).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
The automated process that opens a PR to https://github.com/aws/homebrew-tap is using the wrong file name (
simple-ec2.jsoninstead ofaws-simple-ec2-cli.json), meaning the diff is always wrong and we have to manually open a release PR there with the changes. Here's an example of the most recent incorrect PR: aws/homebrew-tap#360This repo uses different names for the binary and for the brew formula, unlike our other repos. Introduced a new optional parameter to the homebrew sync script to allow specifying a formula name. If not supplied, it will default to the binary name, keeping the same behavior as before.
Some work remains to get this on par with instance-selector (such as adding support for Mac M1 builds).
Testing:
I used this code in a dry-run configuration to generate the diff for aws/homebrew-tap#361, which verified that it works as intended. Next time we release simple-ec2, the GitHub Actions should be able to automatically open the homebrew-tap release PR correctly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.