Skip to content

Commit

Permalink
Suppress cfn_nag warning
Browse files Browse the repository at this point in the history
  • Loading branch information
@biffgaut
biffgaut committed Dec 12, 2023
1 parent 3a20436 commit 7a33919
Show file tree
Hide file tree
Showing 18 changed files with 193 additions and 17 deletions.
12 changes: 11 additions & 1 deletion ...udfront-apigateway-lambda/test/integ.cftaplam-customCloudfrontLoggingBucket.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"cfapigwlambdaCloudFrontToApiGatewayCloudfrontLoggingBucketAccessLogPolicyC05E1C71": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...onstructs/aws-cloudfront-apigateway-lambda/test/integ.cftaplam-no-arguments.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfrontapigatewaylambdaCloudFrontToApiGatewayCloudfrontLoggingBucketAccessLogPolicy521355D8": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...ucts/aws-cloudfront-apigateway-lambda/test/integ.cftaplam-override-behavior.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"cfapilambdaoverrideCloudFrontToApiGatewayCloudfrontLoggingBucketAccessLogPolicy53DB42E0": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...s/aws-cloudfront-apigateway/test/integ.cftapi-customCloudfrontLoggingBucket.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"cfapigwCloudfrontLoggingBucketAccessLogPolicyDB63EA7B": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...lutions-constructs/aws-cloudfront-apigateway/test/integ.cftapi-no-arguments.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfrontapigatewayCloudfrontLoggingBucketAccessLogPolicy1110B389": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...s/aws-cloudfront-mediastore/test/integ.cftmed-customCloudFrontLoggingBucket.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"cloudfrontmediastoreCloudfrontLoggingBucketAccessLogPolicyB512EE2A": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...ws-solutions-constructs/aws-cloudfront-mediastore/test/integ.cftmed-default.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfrontmediastoreCloudfrontLoggingBucketAccessLogPolicy7B05AE89": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...ns-constructs/aws-cloudfront-mediastore/test/integ.cftmed-existingContainer.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfrontmediastoreCloudfrontLoggingBucketAccessLogPolicy7B05AE89": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...s-constructs/aws-cloudfront-mediastore/test/integ.cftmed-overrideProperties.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfrontmediastoreCloudfrontLoggingBucketAccessLogPolicy7B05AE89": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...ucts/aws-cloudfront-mediastore/test/integ.cftmed-withSecurityHeaderBehavior.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,17 @@
}
},
"UpdateReplacePolicy": "Retain",
"DeletionPolicy": "Retain"
"DeletionPolicy": "Retain",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfrontmediastoreCloudfrontLoggingBucketAccessLogPolicy7B05AE89": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...ucts/aws-cloudfront-mediastore/test/integ.cftmed-withoutHttpSecurityHeaders.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfrontmediastoreCloudfrontLoggingBucketAccessLogPolicy7B05AE89": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...@aws-solutions-constructs/aws-cloudfront-s3/test/integ.cfts3-custom-headers.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfronts3CloudfrontLoggingBucketAccessLogPolicy526F2E14": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...s-solutions-constructs/aws-cloudfront-s3/test/integ.cfts3-custom-originPath.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfronts3CloudfrontLoggingBucketAccessLogPolicy526F2E14": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...olutions-constructs/aws-cloudfront-s3/test/integ.cfts3-customLoggingBuckets.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfronts3CloudfrontLoggingBucketAccessLogPolicy526F2E14": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...aws-solutions-constructs/aws-cloudfront-s3/test/integ.cfts3-existing-bucket.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfronts3CloudfrontLoggingBucketAccessLogPolicy526F2E14": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...s/@aws-solutions-constructs/aws-cloudfront-s3/test/integ.cfts3-no-arguments.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfronts3CloudfrontLoggingBucketAccessLogPolicy526F2E14": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
12 changes: 11 additions & 1 deletion ...solutions-constructs/aws-cloudfront-s3/test/integ.cfts3-no-security-headers.expected.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,17 @@
}
},
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
"DeletionPolicy": "Delete",
"Metadata": {
"cfn_nag": {
"rules_to_suppress": [
{
"id": "W35",
"reason": "This S3 bucket is used as the access logging bucket for another bucket"
}
]
}
}
},
"testcloudfronts3nosecurityheadersCloudfrontLoggingBucketAccessLogPolicy3DF5F522": {
"Type": "AWS::S3::BucketPolicy",
Expand Down
6 changes: 6 additions & 0 deletions source/patterns/@aws-solutions-constructs/core/lib/s3-bucket-helper.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ export function createCloudFrontLoggingBucket(scope: Construct,
const combinedBucketProps = consolidateProps(DefaultS3Props(), loggingBucketProps);

const accessLogBucket: s3.Bucket = new s3.Bucket(scope, `${bucketId}AccessLog`, combinedBucketProps); // NOSONAR
addCfnSuppressRules(accessLogBucket, [
{
id: 'W35',
reason: "This S3 bucket is used as the access logging bucket for another bucket"
}
]);

// Create the Logging Bucket
// NOSONAR (typescript:S6281)
Expand Down

0 comments on commit 7a33919

Please sign in to comment.