Add autoDelete, fix name conflicts in integ tests

awslabs · Nov 19, 2023 · 9892363 · 9892363
1 parent 630a57a
commit 9892363
Show file tree

Hide file tree

Showing 77 changed files with 3,048 additions and 713 deletions.
diff --git a/.../aws-eventbridge-kinesisfirehose-s3/test/integ.evtfhss3-customLoggingBucket.expected.json b/.../aws-eventbridge-kinesisfirehose-s3/test/integ.evtfhss3-customLoggingBucket.expected.json
diff --git a/...-constructs/aws-eventbridge-kinesisfirehose-s3/test/integ.evtfhss3-customLoggingBucket.ts b/...-constructs/aws-eventbridge-kinesisfirehose-s3/test/integ.evtfhss3-customLoggingBucket.ts
@@ -23,17 +23,18 @@ const app = new App();
 // Empty arguments
 const stack = new Stack(app, generateIntegStackName(__filename));
 
-new EventbridgeToKinesisFirehoseToS3(stack, 'test-kinesisfirehose-s3', {
+new EventbridgeToKinesisFirehoseToS3(stack, 'evtfhss3-custom-log-bucket', {
   eventRuleProps: {
     schedule: events.Schedule.rate(Duration.minutes(5))
   },
   bucketProps: {
     removalPolicy: RemovalPolicy.DESTROY,
+    autoDeleteObjects: true,
   },
   loggingBucketProps: {
     removalPolicy: RemovalPolicy.DESTROY,
     autoDeleteObjects: true,
-    bucketName: 'custom-logging-bucket',
+    bucketName: `${generateIntegStackName(__filename).toLowerCase()}-custom-logging-bucket`,
     encryption: s3.BucketEncryption.S3_MANAGED,
     versioned: true
   },