Remove ssm string parameter Type references

awslabs · Feb 7, 2023 · e029dda · e029dda
1 parent 466bded
commit e029dda
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 33 deletions.
diff --git a/source/patterns/@aws-solutions-constructs/core/lib/ssm-string-parameter-helper.ts b/source/patterns/@aws-solutions-constructs/core/lib/ssm-string-parameter-helper.ts
@@ -11,9 +11,8 @@
  *  and limitations under the License.
  */
 
-import {ParameterType, StringParameter, StringParameterProps} from 'aws-cdk-lib/aws-ssm';
+import {StringParameter, StringParameterProps} from 'aws-cdk-lib/aws-ssm';
 import {Construct} from 'constructs';
-import {printWarning} from "./utils";
 
 /**
  * Method to build the default AWS SSM Parameter Store
@@ -23,14 +22,5 @@ import {printWarning} from "./utils";
  * @param stringParameterProps
  */
 export function buildSsmStringParameter(scope: Construct, id: string, stringParameterProps: StringParameterProps): StringParameter {
-  let props: StringParameterProps = stringParameterProps;
-
-  if (stringParameterProps.type && stringParameterProps.type !== ParameterType.STRING) {
-    printWarning('Overriding SSM String Parameter type to be ParameterType.STRING');
-    props = {
-      ...stringParameterProps,
-      type: ParameterType.STRING
-    };
-  }
-  return new StringParameter(scope, id, props);
+  return new StringParameter(scope, id, stringParameterProps);
 }
diff --git a/source/patterns/@aws-solutions-constructs/core/test/ssm-string-parameter-helper.test.ts b/source/patterns/@aws-solutions-constructs/core/test/ssm-string-parameter-helper.test.ts
@@ -14,7 +14,6 @@
 import {Stack} from 'aws-cdk-lib';
 import * as defaults from '../';
 import '@aws-cdk/assert/jest';
-import {ParameterType} from 'aws-cdk-lib/aws-ssm';
 
 // --------------------------------------------------------------
 // Test minimal deployment with no properties
@@ -31,23 +30,3 @@ test('Test minimal deployment with required properties', () => {
     Value: parameterValue
   });
 });
-
-// --------------------------------------------------------------
-// Test minimal deployment overriding parameter type
-// --------------------------------------------------------------
-test('Test minimal deployment with required properties', () => {
-  // Stack
-  const stack = new Stack();
-  // Helper declaration
-  const parameterValue = "test-val";
-  defaults.buildSsmStringParameter(stack, 'parameterName',
-    {
-      stringValue: parameterValue,
-      type: ParameterType.STRING_LIST,
-    });
-
-  expect(stack).toHaveResourceLike('AWS::SSM::Parameter', {
-    Type: 'String',
-    Value: parameterValue
-  });
-});