Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(all): Update Code Smell omissions #1004

Merged
merged 1 commit into from
Sep 9, 2023
Merged

chore(all): Update Code Smell omissions #1004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/patterns/@aws-solutions-constructs/core/lib/alb-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export function AddListener(
`${id}-redirect`,
{
loadBalancer,
protocol: ApplicationProtocol.HTTP,
protocol: ApplicationProtocol.HTTP, // NOSONAR
defaultAction: ListenerAction.redirect(opt),
}
);
Expand Down
4 changes: 2 additions & 2 deletions source/patterns/@aws-solutions-constructs/core/lib/s3-bucket-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export function createAlbLoggingBucket(scope: Construct,
// NOSONAR (typescript:typescript:S6249)
// versioning is turned on in the default properties that Sonarqube doesn't see
// Verified by unit test 's3 bucket with default props'
const loggingBucket: s3.Bucket = new s3.Bucket(scope, bucketId, combinedBucketProps);
const loggingBucket: s3.Bucket = new s3.Bucket(scope, bucketId, combinedBucketProps); // NOSONAR

// Extract the CfnBucket from the loggingBucket
const loggingBucketResource = loggingBucket.node.findChild('Resource') as s3.CfnBucket;
Expand Down Expand Up @@ -199,7 +199,7 @@ export function buildS3Bucket(scope: Construct,
// NOSONAR (typescript:typescript:S6249)
// versioning is turned on in the default properties that Sonarqube doesn't see
// Verified by unit test 's3 bucket with default props'
const s3Bucket: s3.Bucket = new s3.Bucket(scope, resolvedBucketId, combinedBucketProps );
const s3Bucket: s3.Bucket = new s3.Bucket(scope, resolvedBucketId, combinedBucketProps ); // NOSONAR

return { bucket: s3Bucket, loggingBucket };
}
Expand Down
4 changes: 2 additions & 2 deletions source/patterns/@aws-solutions-constructs/core/lib/sagemaker-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,8 @@ export function buildSagemakerNotebook(
const sagemakerInstance: sagemaker.CfnNotebookInstance = new sagemaker.CfnNotebookInstance(
scope,
'SagemakerNotebook',
sagemakerNotebookProps
); // NOSONAR
sagemakerNotebookProps // NOSONAR
);
if (vpcInstance) {
return { notebook: sagemakerInstance, vpc: vpcInstance, securityGroup };
} else {
Expand Down