chore(all): reduce cognitive complexity #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biffgaut
requested review from
hayesry,
mobri2a,
emcfins,
mickychetta and
georgebearden
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
georgebearden
approved these changes
Sep 15, 2023
Comment on lines
+604
to
+618
| const containerName = "custom-container-name"; | ||
| const serviceName = "custom-service-name"; | ||
| const familyName = "custom-family-name"; | ||
|
|
||
| const props: FargateToKinesisStreamsProps = { | ||
| publicApi, | ||
| ecrRepositoryArn: defaults.fakeEcrRepoArn, | ||
| clusterProps: { clusterName }, | ||
| containerDefinitionProps: { containerName }, | ||
| fargateTaskDefinitionProps: { family: familyName }, | ||
| fargateServiceProps: { serviceName }, | ||
| existingVpc: defaults.getTestVpc(stack), | ||
| vpcProps: { }, | ||
| }; |
There was a problem hiding this comment.
This code is duplicated in many tests. May be worth creating a function that takes in stack and returns this props object?
There was a problem hiding this comment.
Hmm.... Now I see below that its the same fargate-based params, but the other service making up the construct is in there too. Perhaps still creating the default set of fargate props and passing them to the construct props object with a ...fargateProps call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.