fix(all): typos #1010
Merged
fix(all): typos #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisenkodv
requested review from
biffgaut,
hayesry,
mobri2a,
emcfins,
mickychetta and
georgebearden
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
approved these changes
Sep 18, 2023
| @@ -146,7 +146,7 @@ export class AlbToLambda extends Construct { | |||
| this.lambdaFunction = defaults.buildLambdaFunction(this, { | |||
| existingLambdaObj: props.existingLambdaObj, | |||
| lambdaFunctionProps: props.lambdaFunctionProps, | |||
| vpc: this.vpc, | |||
There was a problem hiding this comment.
we do this on purpose, as it prevents typo errors in maintenance if we add members later. As it is the only edit of this sort and we are far from consistent I'll ignore it.
| this.loadBalancer, | ||
| props.listenerProps | ||
| ); | ||
| this.listener = defaults.AddListener(this, id, this.loadBalancer, props.listenerProps); |
There was a problem hiding this comment.
You can leave this, but I'm not a fan. They are functionally equivalent, there is not a right/wrong aspect. I'm pretty sure the existing format was applied by our autoformatting tool, so will probably reappear in the future when someone says "Format Document"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.