chore(all): clean up bucket behavior in integration tests #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biffgaut
requested review from
hayesry,
mobri2a,
emcfins,
mickychetta and
georgebearden
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
hayesry
approved these changes
Dec 7, 2023
hayesry
added a commit
that referenced
this pull request
Dec 8, 2023
biffgaut
pushed a commit
that referenced
this pull request
Jan 9, 2024
…ls; add support for CMK-encrypted buckets (#1038) * feat: upgrade aws-cloudfront-s3 to use oac instead of oai * feat: added testing and documentation notes * merge: alignment with #1037 * fix: version number for aws-cloudfront-s3 custom resource * fix: edits to custom resource package.json file * fix: issue with installing deps for custom resource * feat: create new S3OacOrigin, consolidate custom resources * chore: change bucket variable naming in 'aws-cloudfront-s3/lib/index.ts' * chore: consolidate custom resources, additional cleanup * chore: update resources/package.json file * chore: add resources dependency to aws-cloudfront-s3 package.json file * chore: edit source/package.json to revert workspaces specification * chore: add aws-cdk-lib to resources/package.json * chore: remove carat from aws-cdk-lib dependency * Update package.json * chore: pr updates * chore: pr updates * chore: update integ tests * chore: update package.json * fix: oac naming and resources/package.json * chore: add cfn suppression statements to custom resource providers where applicable * chore: cfn-nag statements for bucket deployments * chore: remove bucketDeployment samples * chore: update imports and integ tests * chore: update integ tests * chore: updated naming for `defaults.CloudFrontDistributionForS3` function * chore: edited comments for s3-oac-origin.ts * chore: minor organizational improvements to import statements * chore: update custom resource description; remove CWLogs policy statement * chore: naming and spelling * feat: add checking for duplicate key policies by sid * feat: re-add support for legacy HttpOrigin configs * chore: eslint * chore: more eslint * chore: cfn-nag * feat: add printWarning for customers using HttpOrigin * fix: remove warning prefix * chore: add comment on default key policy name specification * chore: additional testing, readme updates * feat: refactored props for createCloudFrontDistributionForS3() * chore: print warnings language updates * chore: switch file naming for shared functions in resources/ * chore: update imports in resources/ * feat: overwrite existing key policy, update unit tests * fix: pass id from the top level through to createCloudFrontDistributionForS3 * chore: update integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Continued efforts to ensure that integration tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.