Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integration test stack descriptions): Corrected inaccurate integ test stack descriptions #884

Merged
merged 2 commits into from
Jan 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .viperlightrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"failOn": "medium",
"all": true
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Description": "Integration Test with new VPC, Service and Table",
"Description": "Integration Test with existing VPC and Service and Table",
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const app = new App();
const stack = new Stack(app, generateIntegStackName(__filename), {
env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
});
stack.templateOptions.description = 'Integration Test with new VPC, Service and Table';
stack.templateOptions.description = 'Integration Test with existing VPC and Service and Table';

const existingVpc = getTestVpc(stack);
const [ existingTable ] = defaults.buildDynamoDBTable(stack, {});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Description": "Integration Test with new VPC, Service and Existing Bucket",
"Description": "Integration Test with existing VPC, Service and Event Bus",
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const app = new App();
const stack = new Stack(app, generateIntegStackName(__filename), {
env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
});
stack.templateOptions.description = 'Integration Test with new VPC, Service and Existing Bucket';
stack.templateOptions.description = 'Integration Test with existing VPC, Service and Event Bus';

const existingVpc = getTestVpc(stack);
const image = ecs.ContainerImage.fromRegistry('nginx');
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Description": "Integration Test with new VPC, Service and Bucket",
"Description": "Integration Test with existing VPC, Service and Bucket",
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const app = new App();
const stack = new Stack(app, generateIntegStackName(__filename), {
env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
});
stack.templateOptions.description = 'Integration Test with new VPC, Service and Bucket';
stack.templateOptions.description = 'Integration Test with existing VPC, Service and Bucket';

const existingVpc = getTestVpc(stack);
const existingBucket = defaults.CreateScrapBucket(stack, {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Description": "Integration Test with new VPC, Service and a Secret",
"Description": "Integration Test with existing VPC, Service and a Secret",
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const app = new App();
const stack = new Stack(app, generateIntegStackName(__filename), {
env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
});
stack.templateOptions.description = 'Integration Test with new VPC, Service and a Secret';
stack.templateOptions.description = 'Integration Test with existing VPC, Service and a Secret';

const existingVpc = getTestVpc(stack);
const existingSecretObj = defaults.buildSecretsManagerSecret(stack, 'secret', {});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Description": "Integration Test with new VPC, Service and Topic",
"Description": "Integration Test with existing VPC, Service and Topic",
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const app = new App();
const stack = new Stack(app, generateIntegStackName(__filename), {
env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
});
stack.templateOptions.description = 'Integration Test with new VPC, Service and Topic';
stack.templateOptions.description = 'Integration Test with existing VPC, Service and Topic';

const existingVpc = getTestVpc(stack);
const existingTopic = new sns.Topic(stack, 'test-topic', {});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Description": "Integration Test with new VPC, Service and Queue",
"Description": "Integration Test with existing VPC, Service and Queue",
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const app = new App();
const stack = new Stack(app, generateIntegStackName(__filename), {
env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
});
stack.templateOptions.description = 'Integration Test with new VPC, Service and Queue';
stack.templateOptions.description = 'Integration Test with existing VPC, Service and Queue';

const existingVpc = getTestVpc(stack);
const existingQueue = new sqs.Queue(stack, 'test-queue', {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Description": "Integration Test with new VPC, Service and SSM String Parameter",
"Description": "Integration Test with existing VPC, Service and SSM String Parameter",
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const app = new App();
const stack = new Stack(app, generateIntegStackName(__filename), {
env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
});
stack.templateOptions.description = 'Integration Test with new VPC, Service and SSM String Parameter';
stack.templateOptions.description = 'Integration Test with existing VPC, Service and SSM String Parameter';

const existingVpc = getTestVpc(stack);
const existingStringParameterObj = new ssm.StringParameter(stack, 'Parameter', {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Description": "Integration Test with new VPC, Service and a state machine with no CloudWatch alarms",
"Description": "Integration Test with existing VPC and Service and a new state machine with no CloudWatch alarms",
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const app = new App();
const stack = new Stack(app, defaults.generateIntegStackName(__filename), {
env: { account: Aws.ACCOUNT_ID, region: 'us-east-1' },
});
stack.templateOptions.description = 'Integration Test with new VPC, Service and a state machine with no CloudWatch alarms';
stack.templateOptions.description = 'Integration Test with existing VPC and Service and a new state machine with no CloudWatch alarms';

const existingVpc = defaults.getTestVpc(stack);
const startState = new stepfunctions.Pass(stack, 'StartState');
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Description": "Integration Test with new resourcesfor aws-lambda-elasticachememcached",
"Description": "Integration Test with existing vpc, Lambda function and cache",
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,10 @@ import { generateIntegStackName, getTestVpc, CreateTestCache, addCfnSuppressRule
// Setup
const app = new App();
const stack = new Stack(app, generateIntegStackName(__filename));
stack.templateOptions.description = 'Integration Test with new resourcesfor aws-lambda-elasticachememcached';
stack.templateOptions.description = 'Integration Test with existing vpc, Lambda function and cache';

const testVpc = getTestVpc(stack, false);

// const testSG = new ec2.SecurityGroup(stack, 'test-sg', {
// vpc: testVpc,
// });
// addCfnSuppressRules(testSG, [{ id: "W40", reason: "Test Resource" }]);
// addCfnSuppressRules(testSG, [{ id: "W5", reason: "Test Resource" }]);
// addCfnSuppressRules(testSG, [{ id: "W36", reason: "Test Resource" }]);
const testSG = buildSecurityGroup(stack, 'test-sg', { vpc: testVpc }, [], []);

const testFunction = new lambda.Function(stack, 'test-function', {
Expand Down