Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

#11 - add multiple form field names for use with different ADFS versions #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

groboclown
Copy link

Issue #, if available:
#11

Description of changes:
Keeps the original ADFS form names, and adds in the alternate UserName and Password fields for compatibility with other login forms. Note that this implementation allows for combinations that aren't expected (old + new form names).

Includes a new unit test for checking the alternate names.

This also includes some minor styling updates to allow make prcheck pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@groboclown groboclown changed the title Fix for #11 - add multiple form field names for use with different ADFS versions #11 - add multiple form field names for use with different ADFS versions Aug 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #39 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage    98.1%   98.11%   +0.01%     
==========================================
  Files           5        5              
  Lines         317      319       +2     
  Branches       42       42              
==========================================
+ Hits          311      313       +2     
  Misses          3        3              
  Partials        3        3
Impacted Files Coverage Δ
awsprocesscreds/saml.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a216e70...820cd42. Read the comment docs.

@dhensen
Copy link

dhensen commented Oct 5, 2020

@JordonPhillips I'm pinging you because you are to be the top contributor.
Can this PR be followed up?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants