Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when resulting response is over 4096 bytes #3

Closed
NightKhaos opened this issue Apr 3, 2018 · 1 comment
Closed

Throw an error when resulting response is over 4096 bytes #3

NightKhaos opened this issue Apr 3, 2018 · 1 comment
Assignees
@NightKhaos
Labels
enhancement needs-testing
Milestone
1.2

Comments

@NightKhaos
Copy link

CloudFormation cannot accept objects over 4096 bytes. This will result in a signal failure. We should therefore catch the case when the response exceeds more than 4096 bytes and throw a FAILED event instead.
@NightKhaos NightKhaos added this to the 1.1 milestone Apr 3, 2018
@NightKhaos NightKhaos self-assigned this Apr 3, 2018
@NightKhaos NightKhaos modified the milestones: 1.1, 1.2 May 10, 2018
taylorb-syd added a commit that referenced this issue Feb 15, 2021
@taylorb-syd
[Issue #3] Introduced logic to check size of response. Refactored dec…
e28cb52 
…orator exception handling.
taylorb-syd added a commit that referenced this issue Feb 15, 2021
@taylorb-syd
[Issue #3 C2] Merge Conflict Resolution with Issue #18
407f301
@taylorb-syd
Copy link
Contributor

taylorb-syd commented Feb 15, 2021 •
edited
Loading

Requires testing, merged progress into main. Testing likely written on top of main for Issue #2

@taylorb-syd taylorb-syd mentioned this issue Feb 15, 2023
Merged
taylorb-syd added a commit that referenced this issue Feb 15, 2023
@taylorb-syd
[1.20] Completed Milestones for 1.2.0 release
04296e7 
* [Issue #18] Changed Whitelist/Blacklist to Allowlist/Blocklist, Refactored Code, Improved Testing Code, Improved README.md grammar

* [Issue #3] Introduced logic to check size of response. Refactored decorator exception handling.

* [Issue #4] Introduced a function to collapse the output data and used this in the cfnresponse function

* [1.2.0rc1] Documentation Pass to improve README.md

* [Issue #2] Implemented Unit Tests

* [Issue #21] Added the response headers for troubleshooting to the debug log output
taylorb-syd added a commit that referenced this issue Feb 15, 2023
@taylorb-syd
[1.2.0] Completed Milestones for 1.2.0 release
c416b40 
* [Issue #18] Changed Whitelist/Blacklist to Allowlist/Blocklist, Refactored Code, Improved Testing Code, Improved README.md grammar

* [Issue #3] Introduced logic to check size of response. Refactored decorator exception handling.

* [Issue #4] Introduced a function to collapse the output data and used this in the cfnresponse function

* [1.2.0rc1] Documentation Pass to improve README.md

* [Issue #2] Implemented Unit Tests

* [Issue #21] Added the response headers for troubleshooting to the debug log output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NightKhaos NightKhaos

Labels
enhancement needs-testing
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
2 participants
@NightKhaos @taylorb-syd